-
-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change LinearCyclicalScheduler to triangle wave to sawtooth wave #3186
Conversation
triangle to sawtooth
Thanks for the PR and opening a corresponding feature request, @sihyeong671 ! |
got it! I think that is a good idea.I will try add optional flag |
add optional flag for triangle and sawtooth wave
- move value error location to __init__ - rename use_legacy to use_sawtooth
…into feat/scheduler
…est" This reverts commit 6d10fde.
- add monotonic variable - check Error case
- warmup_duration, monotonic Value Error Check - add test case for linear cyclical scheduler with warmup_duration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks a lot for the contribution, @sihyeong671 !
Fixes #3185
Description:
Add monotonic variable in LinearCyclicalScheduler
LinearCyclicalScheduler's get_param method is modified
Add Test case LinearCyclicalScheduler ValueError
Add Test case LinearCyclicalScheduler with warmup duration
Check list: