Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error when testing xla in cosine similarity metric #3213

Merged
merged 24 commits into from
Mar 20, 2024
Merged

Fix error when testing xla in cosine similarity metric #3213

merged 24 commits into from
Mar 20, 2024

Conversation

kzkadc
Copy link
Contributor

@kzkadc kzkadc commented Mar 20, 2024

Fixes #3203 (comment)

Description:

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

kzkadc and others added 23 commits March 14, 2024 19:44
@kzkadc
add cosine similarity
c7f0a1a
@kzkadc
update doc for cosine similarity metric
9c87580
@kzkadc
fix the position of the CosineSimilarity
12a4d56
@kzkadc @vfdev-5
Update ignite/contrib/metrics/cosine_similarity.py
e09b86f 
Co-authored-by: vfdev <vfdev.5@gmail.com>
@kzkadc @github-actions
autopep8 fix
99852d5
@kzkadc
move CosineSimilarity from contrib.metrics to metrics
54c16c1
@kzkadc @github-actions
autopep8 fix
9524d20
@kzkadc
fix typo
b7dd7ea
@kzkadc
Merge branch 'cosine_similarity' of github.com:kzkadc/ignite into cos…
ef33b49 
…ine_similarity
@kzkadc
fix typo
52aeaee
@kzkadc @vfdev-5
Update ignite/metrics/cosine_similarity.py
78b4029 
Co-authored-by: vfdev <vfdev.5@gmail.com>
@kzkadc @github-actions
autopep8 fix
6bfbe88
@kzkadc @vfdev-5
Update ignite/metrics/cosine_similarity.py
a83e02c 
Co-authored-by: vfdev <vfdev.5@gmail.com>
@kzkadc
fix formatting
9e4fd31
@kzkadc @github-actions
autopep8 fix
377baea
@kzkadc
Merge branch 'cosine_similarity' of github.com:kzkadc/ignite into cos…
87d2854 
…ine_similarity
@kzkadc
fix formatting
ad16ce7
@kzkadc @github-actions
autopep8 fix
6d3193e
@kzkadc
add test for CosineSimilarity metric
b2b8de4
@kzkadc @github-actions
autopep8 fix
8156dc6
@vfdev-5
Merge branch 'master' into cosine_similarity
0cd8440
@vfdev-5
Merge branch 'master' into cosine_similarity
0778d07
@kzkadc
fix error when testing in xla
d05f854
@github-actions github-actions bot added docs module: metrics Metrics module labels Mar 20, 2024
@kzkadc kzkadc mentioned this pull request Mar 20, 2024
Merged
3 tasks
vfdev-5
vfdev-5 approved these changes Mar 20, 2024
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kzkadc , lgtm

@vfdev-5 vfdev-5 merged commit 3d8f3ec into pytorch:master Mar 20, 2024
10 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees
No one assigned
Labels
docs module: metrics Metrics module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kzkadc @vfdev-5