Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added python 3.12 dependency in CI #3219

Merged
merged 21 commits into from
Mar 26, 2024
Merged

Conversation

avinashsharma080
Copy link
Contributor

@avinashsharma080 avinashsharma080 commented Mar 26, 2024

Fixes #3206

Description: Added python 3.12 to matrix in unit-test.yml and fixed extra whitespace in mnist.py

@github-actions github-actions bot added examples Examples ci CI labels Mar 26, 2024
@avinashsharma080 avinashsharma080 marked this pull request as ready for review March 26, 2024 12:16
.vscode/settings.json Outdated Show resolved Hide resolved
@vfdev-5
Copy link
Collaborator

vfdev-5 commented Mar 26, 2024

@avinashsharma080 as you said on discord, py312 is failing on some nlp metrics due to removed _normalize arg in Fraction:

return Fraction(numerator, denominator, _normalize=False)

TypeError: Fraction.__new__() got an unexpected keyword argument '_normalize'

Can you remove _normalize arg everywhere it is used to see if it is really needed?

- return Fraction(numerator, denominator, _normalize=False)
+ return Fraction(numerator, denominator)

Actually, it is nltk's code and not ignite.

Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vfdev-5 vfdev-5 merged commit 42c4d29 into pytorch:master Mar 26, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci CI examples Examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add python 3.12 to CI
3 participants