Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix device compatibility for PearsonCorrelation metric #3223

Merged
merged 23 commits into from
Mar 31, 2024
Merged

Fix device compatibility for PearsonCorrelation metric #3223

merged 23 commits into from
Mar 31, 2024

Conversation

kzkadc
Copy link
Contributor

@kzkadc kzkadc commented Mar 31, 2024 •
edited by vfdev-5

Fixes #3212 (comment)

Description:

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

kzkadc and others added 22 commits March 20, 2024 18:20
@kzkadc
add PearsonCorrelation metric
dba3049
@kzkadc
match the notation of the docstring with the other metrics
1f80ede
@kzkadc
Merge branch 'master' into correlation-coefficient
d5f3b0c
@kzkadc
move PearsonCorrelation metric from contrib.metrics.regression to met…
69f7f5e 
…rics.regression
@kzkadc
update test for PearsonCorrelation metric
855a505
@kzkadc
update test
6b17c36
@kzkadc
Merge branch 'master' into correlation-coefficient
fb5b8f4
@kzkadc
Merge branch 'correlation-coefficient_rewrite-test' into correlation-…
194f213 
…coefficient
@kzkadc
Merge branch 'master' into correlation-coefficient
7b1acd3
@kzkadc
Merge branch 'master' into correlation-coefficient
62e65d2
@kzkadc
Merge branch 'master' into correlation-coefficient
ce701bc
@kzkadc
modify doc for PearsonCorrelation metric
b931ec9
@kzkadc
fix import
6609925
@kzkadc
resolve code formatting issue
9069779
@kzkadc
remove loop from test
4a0096d
@vfdev-5
Merge branch 'master' into correlation-coefficient
1de9181
@kzkadc @vfdev-5
Update ignite/metrics/regression/pearson_correlation.py
ad1e090 
Co-authored-by: vfdev <vfdev.5@gmail.com>
@vfdev-5
Update pearson_correlation.py
4d6b18e
@kzkadc
update test for PearsonCorrelation
ad41bbc
@vfdev-5
Update tests/ignite/metrics/regression/test_pearson_correlation.py
30f1684
@kzkadc
relax pytest.approx
c6b6d92
@kzkadc
fix device compatibility
bb93a5e
@github-actions github-actions bot added docs module: metrics Metrics module labels Mar 31, 2024
vfdev-5
vfdev-5 approved these changes Mar 31, 2024
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kzkadc !

@vfdev-5 vfdev-5 merged commit 53d641d into pytorch:master Mar 31, 2024
17 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees
No one assigned
Labels
docs module: metrics Metrics module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kzkadc @vfdev-5