Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed mkl from dev deps #3226

Merged
merged 7 commits into from
Apr 1, 2024
Merged

Removed mkl from dev deps #3226

merged 7 commits into from
Apr 1, 2024

Conversation

vfdev-5
Copy link
Collaborator

@vfdev-5 vfdev-5 commented Apr 1, 2024

Description:

Context: We have now failing tests for GHA pytorch version tests: https://github.com/pytorch/ignite/actions/runs/8444583767

 Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/usr/share/miniconda3/envs/test/lib/python3.8/site-packages/torch/__init__.py", line 218, in <module>
    from torch._C import *  # noqa: F403
ImportError: /usr/share/miniconda3/envs/test/lib/python3.8/site-packages/torch/lib/libtorch_cpu.so: undefined symbol: iJIT_NotifyEvent

The failure is due to mkl incompatibility between conda's installed version and the one installed by pip from requirements-dev.txt

We added mkl in this PR: #1971 due to failing CI on pytorch nightly at that time.

@github-actions github-actions bot added the ci CI label Apr 1, 2024
@vfdev-5 vfdev-5 marked this pull request as ready for review April 1, 2024 10:32
@vfdev-5 vfdev-5 enabled auto-merge (squash) April 1, 2024 10:33
@vfdev-5 vfdev-5 merged commit b828059 into master Apr 1, 2024
18 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant