Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix scheduled tests #3253

Closed

Conversation

leej3
Copy link
Collaborator

@leej3 leej3 commented May 29, 2024

This should fix the failing scheduled tests. Pytest isn't found for them. These tests use the setup-miniconda action for python env installation. The action needs a bash login shell in subsequent steps for the env to be active.

Here's a description of the problem: https://stackoverflow.com/questions/72703363/how-to-activate-conda-environment-in-github-actions

Also torch.backends.mps does not exist for older pytorch versions and "filelock" should be listed explicitly as a dependency.

add better error message when pytest is not on the PATH
@leej3 leej3 requested a review from vfdev-5 May 29, 2024 08:49
@github-actions github-actions bot added the ci CI label May 29, 2024
@vfdev-5
Copy link
Collaborator

vfdev-5 commented May 29, 2024

@leej3 leej3 mentioned this pull request May 29, 2024
@leej3 leej3 closed this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants