-
-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip unrolling follow up #3260
Skip unrolling follow up #3260
Conversation
This is just an initial PR. I am currently working on the remaining classes. |
…st_cosine_similarity
…aximum_mean_discrepancy.py
…cy.py and test_mean_pairwise_distance.py
…usion_matrix.py, test_multilabel_confusion_matrix.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the PR with all those meticulous updates!
I left few comments to improve it.
I don't think these classes require skip_unrolling feature. Lmk. |
Yes, we can skip GpuInfo and MetricsLambda, but we still need to add it to Frequency for consistency. |
Have updated the Frequency class as well. Args were missing in docstring, added them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot for the PR, @simeetnayan81 !
Good to go once the CI is green (as we ignore failing TPU test)
Description: Follow up PR for adding argument skip_unrolling in Metric Class. #3258
Following classes need to be updated:
Modification might also be required to related classes.
Check list: