Skip to content

Commit

Permalink
Remove unused variables in manifold/service/TxThrottlingWrappers.cpp
Browse files Browse the repository at this point in the history
Summary:
LLVM-15 has a warning `-Wunused-but-set-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance.

This diff either (a) removes an unused variable and, possibly, it's associated code, or (b) qualifies the variable with `[[maybe_unused]]`, mostly in cases where the variable _is_ used, but, eg, in an `assert` statement that isn't present in production code.

 - If you approve of this diff, please use the "Accept & Ship" button :-)

Reviewed By: palmje

Differential Revision: D54931237

fbshipit-source-id: e8ed38f4359537a4a3e4e97afaf1a41c49d2b413
  • Loading branch information
r-barnes authored and facebook-github-bot committed Mar 15, 2024
1 parent 62b1545 commit b3fb084
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions multipy/runtime/deploy.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,12 @@ const std::initializer_list<InterpreterSymbol> pythonInterpreterSymbols = {
"_binary_libtorch_deployinterpreter_hip_so_end",
false},
};
#ifndef FBCODE_CAFFE2
const std::initializer_list<ExeSection> multipyTorchSections = {
{".torch_deploy_payload.multipy_torch", false},
};
const std::initializer_list<InterpreterSymbol> multipyTorchSymbols = {};
#endif

InterpreterManager::InterpreterManager(
size_t nInterp,
Expand Down

0 comments on commit b3fb084

Please sign in to comment.