Disable pybind11's GIL checks #325
Conversation
|
Hi @lalaland! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
CC @Skylion007 |
|
Hmm. Not sure why the CLA check is failing. I signed the CLA. |
|
@EthanSteinberg Is the email address you used to author the commits part of you GH account? that could be causing it. |
facebook-github-bot
added
the
CLA Signed
|
@Skylion007 Looks like it fixed itself. I guess it just took a second. |
|
@albanD has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This is in particular to have pytorch/multipy#325 which will unblock #105245 Pull Request resolved: #105344 Approved by: https://github.com/malfet, https://github.com/Skylion007
pybind11 recently added a feature to assert that the GIL is held during reference counting operations pybind/pybind11#4246
This feature has already uncovered several instances of undefined behavior in several Python extensions.
However, this code does not seem to pass these checks, which is preventing us from upgrading PyTorch to the latest pybind11. See pytorch/pytorch#105245
This PR disables those checks, which will in turn allow PyTorch to upgrade.
Note that this code already has known potential GIL issues:
multipy/multipy/runtime/deploy.cpp
Line 59 in bd1c76f