Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quantile Regression Loss #38035

Open
vincentqb opened this issue May 7, 2020 · 3 comments
Open

Quantile Regression Loss #38035

vincentqb opened this issue May 7, 2020 · 3 comments
Labels
module: nn Related to torch.nn OSS contribution wanted PR from open source contributors welcome to solve this issue. triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@vincentqb
Copy link
Contributor

vincentqb commented May 7, 2020

When interested in fitting an unknown probability distribution using a neural network model, we are sometimes interested in quantile regression. I suggest we add the quantile regression loss to the losses we have in pytorch.

cc @albanD @mruberry

@vincentqb vincentqb added module: nn Related to torch.nn triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels May 7, 2020
@mruberry mruberry added the OSS contribution wanted PR from open source contributors welcome to solve this issue. label May 11, 2020
@mruberry
Copy link
Collaborator

Great idea, @vincentqb!

@maxmarketit
Copy link

maxmarketit commented Jun 13, 2020

I have implemented QuantileLoss and QinputLoss in this notebook.

I followed the pytorch Loss Class and I do not know anything about torch.jit.is_scripting() part so it is all commented out. Anyone might help here.

It works fine in the example and I tested it with p(p>2) input features and even q(q>2) output features(for QinputLoss, and I figure I should have generalized the QuantileLoss too with tensor output like batch size * output variables * quantiles).

Take a look at it and be free to say any suggestions.

https://github.com/maxmarketit/Auto-PyTorch/blob/develop/examples/quantiles/Quantiles.ipynb

ps) QinputLoss is from Tagasovska, N., & Lopez-Paz, D. (2018). Single-Model Uncertainties for Deep Learning. https://arxiv.org/abs/1811.00908v3.

@Javicadserres
Copy link

Javicadserres commented Jul 19, 2023

Hi, I don't know if there has been any update on this topic but I have implemented the Quantile loss function vectorized here with Pytorch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: nn Related to torch.nn OSS contribution wanted PR from open source contributors welcome to solve this issue. triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants