Make hash_storage work with size 0/1 storage #100467
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edward Z. Yang <ezyang@meta.com> [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/100467
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ 2 Unrelated FailuresAs of commit cc536b8: BROKEN TRUNK - The following jobs failed but were present on the merge base ab65bac:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
github-actions
bot
requested review from
albanD,
antoniojkim,
bdhirsh,
jbschlosser,
miladm,
SherlockNoMad,
voznesenskym and
wconstab
This was referenced May 2, 2023
Signed-off-by: Edward Z. Yang <ezyangmeta.com> [ghstack-poisoned]
Signed-off-by: Edward Z. Yang <ezyangmeta.com> [ghstack-poisoned]
ezyang
added
ciflow/trunk
Skylion007
approved these changes
May 2, 2023
bdhirsh
reviewed
May 2, 2023
| @@ -120,7 +120,6 @@ def kernel(x): | |||
| if pad > 0: | |||
| x = F.pad(x, (0, pad), "constant", 0) | |||
| x = x.view(torch.int32) | |||
| torch._dynamo.mark_dynamic(x, 0) | |||
There was a problem hiding this comment.
Why do we not want this anymore? (is mark_dynamic not robust to dims known to be size 0/1?)
There was a problem hiding this comment.
I need to fix the constraint checker but it is a more involved change
There was a problem hiding this comment.
Right now it errors saying we couldn't make the 1 size dim dynamic.
voznesenskym
approved these changes
May 3, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Signed-off-by: Edward Z. Yang ezyang@meta.com