Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TP] Add API logging for TP high level API #102209

Closed
wants to merge 1 commit into from
Closed

[TP] Add API logging for TP high level API #102209

wants to merge 1 commit into from

Conversation

fduwjj
Copy link
Contributor

@fduwjj fduwjj commented May 24, 2023 •
edited
Loading

@pytorch-bot pytorch-bot bot added the release notes: distributed (fsdp) release notes category label May 24, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented May 24, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/102209

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit e0921a2:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

fduwjj added a commit that referenced this pull request May 24, 2023
@fduwjj
[TP] Add API logging for TP high level API
90f85d1 
ghstack-source-id: bd2a0f79fe92442f666c4a5f953a1a52d96c2d7e
Pull Request resolved: #102209
@fduwjj fduwjj added release notes: distributed (dtensor) release notes category module: logging Features which make it easier to tell what PyTorch is doing under the hood better-engineering Relatively self-contained tasks for better engineering contributors ciflow/trunk Trigger trunk jobs on your pull request labels May 24, 2023
wz337
wz337 approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@wz337 wz337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wanchaol
wanchaol approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@wanchaol wanchaol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

torch/distributed/tensor/parallel/api.py Show resolved Hide resolved
@wanchaol wanchaol removed the release notes: distributed (fsdp) release notes category label May 25, 2023
@fduwjj
Copy link
Contributor Author

fduwjj commented May 25, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

This was referenced May 31, 2023
Closed
Closed
Closed
@fduwjj fduwjj mentioned this pull request Jun 7, 2023
Closed
@facebook-github-bot facebook-github-bot deleted the gh/fduwjj/90/head branch June 8, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wz337 wz337 wz337 approved these changes

@wanchaol wanchaol wanchaol approved these changes

@mrshenli mrshenli Awaiting requested review from mrshenli

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

@rohan-varma rohan-varma Awaiting requested review from rohan-varma

@H-Huang H-Huang Awaiting requested review from H-Huang

@awgu awgu Awaiting requested review from awgu

@kwen2501 kwen2501 Awaiting requested review from kwen2501

@fegin fegin Awaiting requested review from fegin

@kiukchung kiukchung Awaiting requested review from kiukchung

@d4l3k d4l3k Awaiting requested review from d4l3k

Assignees
No one assigned
Labels
better-engineering Relatively self-contained tasks for better engineering contributors ciflow/trunk Trigger trunk jobs on your pull request Merged module: logging Features which make it easier to tell what PyTorch is doing under the hood release notes: distributed (dtensor) release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fduwjj @pytorchmergebot @wanchaol @wz337