[FSDP] Fix for optim state dict #102901
Closed
[FSDP] Fix for optim state dict #102901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for HSDP + use_orig_params where we need to pass in the PG that might not be the default. Differential Revision: [D46417327](https://our.internmc.facebook.com/intern/diff/D46417327/) [ghstack-poisoned]
rohan-varma
requested review from
mrshenli,
zhaojuanmao,
H-Huang,
awgu,
kwen2501,
wanchaol,
fegin,
kiukchung and
d4l3k
as code owners
pytorch-bot
bot
added
the
release notes: distributed (fsdp)
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/102901
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 84be448: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
rohan-varma
added a commit
that referenced
this pull request
Jun 3, 2023
Fix for HSDP + use_orig_params where we need to pass in the PG that might not be the default. Differential Revision: [D46417327](https://our.internmc.facebook.com/intern/diff/D46417327/) ghstack-source-id: 191112222 Pull Request resolved: #102901
wz337
approved these changes
Jun 5, 2023
| @@ -1349,6 +1349,7 @@ def _optim_state_dict( | |||
| state = ( | |||
| {} if param_key is None else optim_state_dict["state"][param_key] | |||
| ) | |||
| print(f"RV: calling _Gather_orig_param_state") | |||
There was a problem hiding this comment.
ditto on the others before landing :)
awgu
reviewed
Jun 5, 2023
| @@ -1497,7 +1498,9 @@ def _all_gather_optim_state( | |||
| object_list: List[StateInfo] = [ | |||
| processed_state for _ in range(fsdp_state.world_size) | |||
| ] | |||
| dist.all_gather_object(object_list, processed_state) | |||
| assert fsdp_state.world_size == fsdp_state.process_group.size() | |||
| @@ -1349,6 +1349,7 @@ def _optim_state_dict( | |||
| state = ( | |||
| {} if param_key is None else optim_state_dict["state"][param_key] | |||
| ) | |||
| print(f"RV: calling _Gather_orig_param_state") | |||
There was a problem hiding this comment.
ditto on the others before landing :)
Fix for HSDP + use_orig_params where we need to pass in the PG that might not be the default. Differential Revision: [D46417327](https://our.internmc.facebook.com/intern/diff/D46417327/) [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Jun 5, 2023
Pull Request resolved: #102901 Fix for HSDP + use_orig_params where we need to pass in the PG that might not be the default. ghstack-source-id: 191231200 Differential Revision: [D46417327](https://our.internmc.facebook.com/intern/diff/D46417327/)
Fix for HSDP + use_orig_params where we need to pass in the PG that might not be the default. Differential Revision: [D46417327](https://our.internmc.facebook.com/intern/diff/D46417327/) [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Jun 6, 2023
Pull Request resolved: #102901 Fix for HSDP + use_orig_params where we need to pass in the PG that might not be the default. ghstack-source-id: 191337799 Differential Revision: [D46417327](https://our.internmc.facebook.com/intern/diff/D46417327/)
|
@pytorchbot merge -f "CI done" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
wz337
added
suppress-bc-linter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Fix for HSDP + use_orig_params where we need to pass in the PG that
might not be the default.
Differential Revision: D46417327