[FSDP] Validate ignored_modules, ignored_states
#104273
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/104273
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 551110e: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
the
release notes: distributed (fsdp)
This was referenced Jun 27, 2023
This checks that `ignored_modules` and `ignored_states` have the expected type and provides a reasonable error message if not. Otherwise, if someone passes a mix of modules and parameters to `ignored_states` for example, then our code may be silently incorrect. [ghstack-poisoned]
rohan-varma
approved these changes
Jun 27, 2023
Composable API uses the same code path, so I think the concern is more about unit testing. |
awgu
requested review from
mrshenli,
zhaojuanmao,
H-Huang,
kwen2501,
wanchaol,
fegin,
fduwjj,
kiukchung and
d4l3k
as code owners
vkallesh
pushed a commit
to amd/ZenDNN-pytorch
that referenced
this pull request
Jul 5, 2023
ghstack-source-id: 356d1a8c5a674d7259fbb028989385ed78681f3b Pull Request resolved: pytorch/pytorch#104273
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
ignored_states+ auto wrap #104275ignored_modules,ignored_states#104273ignored_statesdoc #104253This checks that
ignored_modulesandignored_stateshave the expected type and provides a reasonable error message if not. Otherwise, if someone passes a mix of modules and parameters toignored_statesfor example, then our code may be silently incorrect.