[ONNX] Move symbolic export to separate file #95650
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/95650
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 54e5377: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
the
release notes: onnx
3 tasks
[ghstack-poisoned]
This was referenced Feb 28, 2023
Move things around in the effort of preparing to refactor the code structure. [ghstack-poisoned]
This was referenced Mar 3, 2023
wschin
reviewed
Mar 3, 2023
|
|
||
|
|
||
| @_beartype.beartype | ||
| def _trace_into_fx_graph_via_fx_symbolic_trace( |
There was a problem hiding this comment.
Will attempt in a follow up.
wschin
reviewed
Mar 3, 2023
|
|
||
|
|
||
| @_beartype.beartype | ||
| def _move_placeholder_to_front(graph_module: torch.fx.GraphModule) -> None: |
There was a problem hiding this comment.
There are some graph transforms in this file. They are good candidates for new Transform classes.
There was a problem hiding this comment.
Done in the pass PR.
titaiwangms
approved these changes
Mar 6, 2023
BowenBao
added
topic: improvements
Move things around in the effort of preparing to refactor the code structure. [ghstack-poisoned]
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 12, 2023
Move things around in the effort of preparing to refactor the code structure. Pull Request resolved: pytorch/pytorch#95650 Approved by: https://github.com/titaiwangms
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 12, 2023
Move things around in the effort of preparing to refactor the code structure. Pull Request resolved: pytorch/pytorch#95650 Approved by: https://github.com/titaiwangms
ydwu4
added a commit
to ydwu4/pytorch
that referenced
this pull request
Mar 13, 2023
Move things around in the effort of preparing to refactor the code structure. Pull Request resolved: pytorch#95650 Approved by: https://github.com/titaiwangms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
torch.onnx._internal.fxif ImportError #95686Move things around in the effort of preparing to refactor
the code structure.