Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vulkan] Fix static analysis errors in vulkan_quantized_api_test.cpp #97400

Closed
wants to merge 1 commit into from
Closed

[Vulkan] Fix static analysis errors in vulkan_quantized_api_test.cpp #97400

wants to merge 1 commit into from

Conversation

manuelcandales
Copy link
Contributor

Summary:
Fixes many static analysis and linter issues present in vulkan_quantized_api_test.cpp.
Replaces C-style rand function by Cpp rand functions.

Test Plan:

buck run --target-platforms ovr_config//platform/macos:arm64-fbsource -c pt.vulkan_full_precision=1 //xplat/caffe2:pt_vulkan_quantized_api_test_binAppleMac\#macosx-arm64

Differential Revision: D44315235

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 23, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/97400

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 151120f:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: vulkan release notes category label Mar 23, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44315235

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44315235

@manuelcandales @facebook-github-bot
[Vulkan] Fix static analysis errors in vulkan_quantized_api_test.cpp (p…
151120f 
…ytorch#97400)

Summary:
Pull Request resolved: pytorch#97400

Fixes many static analysis and linter issues present in vulkan_quantized_api_test.cpp.
Replaces C-style rand function by Cpp rand functions.

Test Plan:
```
buck run --target-platforms ovr_config//platform/macos:arm64-fbsource -c pt.vulkan_full_precision=1 //xplat/caffe2:pt_vulkan_quantized_api_test_binAppleMac\#macosx-arm64
```

Reviewed By: kimishpatel

Differential Revision: D44315235

fbshipit-source-id: 15fda2363169d9c21079416204ceb1179aee557c
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44315235

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 23, 2023
@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimishpatel kimishpatel kimishpatel approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged release notes: vulkan release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@manuelcandales @facebook-github-bot @pytorchmergebot @kimishpatel