Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ONNX] Remove the _jit_pass_onnx_scalar_type_analysis pass #97729

Closed
wants to merge 1 commit into from
Closed

[ONNX] Remove the _jit_pass_onnx_scalar_type_analysis pass #97729

wants to merge 1 commit into from

Conversation

justinchuby
Copy link
Collaborator

It doesn't do anything because it doesn't analyze function calls.

@justinchuby
[ONNX] Remove the _jit_pass_onnx_scalar_type_analysis pass
92ce498 
It doesn't do anything because it doesn't analyze function calls.
@justinchuby justinchuby added the module: onnx Related to torch.onnx label Mar 28, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 28, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/97729

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 92ce498:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Mar 28, 2023
@justinchuby
Copy link
Collaborator Author

@pytorchbot merge -g

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 28, 2023

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: unrecognized arguments: -g

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci} ...

Try @pytorchbot --help for more info.

@justinchuby
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 28, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@justinchuby
Copy link
Collaborator Author

@pytorchbot merge -f "all onnx tests passed"

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled. If you believe this is a mistake,then you can re trigger it through pytorch-bot.

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@justinchuby justinchuby deleted the justinchu/remove-apply branch September 9, 2023 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@titaiwangms titaiwangms titaiwangms approved these changes

@wschin wschin Awaiting requested review from wschin

@BowenBao BowenBao Awaiting requested review from BowenBao

@abock abock Awaiting requested review from abock

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: onnx Related to torch.onnx open source release notes: onnx torch.onnx related changes that should show up in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@justinchuby @pytorchmergebot @titaiwangms @pytorchbot