Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[reland][BE][autograd Function] Raise an error if input is returned a… #98051

Closed

Conversation

soulitzer
Copy link
Contributor

…s-is and saved for forward or backward in setup_context

Fixes #ISSUE_NUMBER

Relanding this in a new non-ghstack PR so I can import this to do co-dev

@soulitzer soulitzer requested a review from zou3519 March 31, 2023 01:21
@soulitzer soulitzer requested a review from albanD as a code owner March 31, 2023 01:21
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 31, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/98051

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit dde5568:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@soulitzer soulitzer added release notes: autograd release notes category topic: improvements topic category labels Mar 31, 2023
@facebook-github-bot
Copy link
Contributor

@soulitzer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@soulitzer soulitzer added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 31, 2023
Copy link
Contributor

@zou3519 zou3519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good luck on the codev

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44565561

@soulitzer soulitzer force-pushed the custom_function_fix_for_codev branch from aa58659 to e27c556 Compare March 31, 2023 15:30
soulitzer added a commit to soulitzer/pytorch that referenced this pull request Mar 31, 2023
pytorch#98051)

Summary:
…s-is and saved for forward or backward in setup_context

Fixes #ISSUE_NUMBER

Relanding this in a new non-ghstack PR so I can import this to do co-dev

Pull Request resolved: pytorch#98051

Reviewed By: zou3519

Differential Revision: D44565561

Pulled By: soulitzer

fbshipit-source-id: 2c2af44e020b90deaedc2e5286620ecb2d437966
@facebook-github-bot
Copy link
Contributor

@soulitzer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@atalman
Copy link
Contributor

atalman commented Apr 3, 2023

Please do not land it, we are trying to revert co-dev diff that is already landed for this PR

@facebook-github-bot
Copy link
Contributor

@soulitzer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

pytorch#98051)

Summary:
…s-is and saved for forward or backward in setup_context

Fixes #ISSUE_NUMBER

Relanding this in a new non-ghstack PR so I can import this to do co-dev

Pull Request resolved: pytorch#98051

Reviewed By: zou3519

Differential Revision: D44747382

Pulled By: soulitzer

fbshipit-source-id: e3d7fad3c847d8ef96e2c06654ab9449771b092a
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44747382

@soulitzer soulitzer force-pushed the custom_function_fix_for_codev branch from 76d3ded to dde5568 Compare April 10, 2023 15:42
@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

1 similar comment
@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged merging release notes: autograd release notes category topic: improvements topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants