Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ONNX] Safely set node name for 'replace_placeholder_name_and_target' #98633

Closed
wants to merge 4 commits into from

Conversation

BowenBao
Copy link
Collaborator

@BowenBao BowenBao commented Apr 7, 2023

@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Apr 7, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Apr 7, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/98633

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit 277c661:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@BowenBao BowenBao added module: onnx Related to torch.onnx topic: improvements topic category labels Apr 7, 2023
…ace_placeholder_name_and_target'"

[ghstack-poisoned]
@BowenBao BowenBao marked this pull request as ready for review April 8, 2023 01:11
@BowenBao BowenBao requested a review from abock as a code owner April 8, 2023 01:11
BowenBao added a commit that referenced this pull request Apr 8, 2023
ghstack-source-id: 9303b2c7b553e570fed62e4106b8e9b8ef65ca26
Pull Request resolved: #98633
@BowenBao BowenBao added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 8, 2023
BowenBao added a commit that referenced this pull request Apr 10, 2023
ghstack-source-id: 34946e8ac33516e835374794ead9d3964f223f1f
Pull Request resolved: #98633
@BowenBao
Copy link
Collaborator Author

@pytorchbot merge -f "unrelated macos sympy module not found error"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/BowenBao/227/head branch June 8, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged merging module: onnx Related to torch.onnx open source release notes: onnx torch.onnx related changes that should show up in the release notes topic: improvements topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants