Fix inconsistent torch.nn.MaxPool1d output on cpu and gpu

[tfsingh]

Fixes #99412 , correctly raising an error when an output of invalid size is calculated.

Would be happy to iterate on this if there are any issues.

cc @malfet @jbschlosser

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/99843

• 📄 Preview Python docs built from this PR
• 📄 Preview C++ docs built from this PR
• ❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 7025c3d:

NEW FAILURES - The following jobs have failed:

• BC Lint (gh)
• Check Labels (gh)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[tfsingh]

Hi @mikaylagawarecki , were you able to take a look at this pr? Apologies for the ping, would just love to get this merged.

[mikaylagawarecki]

Hey @tfsingh , so sorry for the delay! Could you add a test in test_nn that ensures the inconsistency is fixed please!

[tfsingh]

Of course, I just added one. I used self.assertRaises to make the CI tests pass, but I'm not sure why assertRaisesrRegex wasn't working in commit e6ae619:

AssertionError: "max_pool1d() Invalid computed output size: 0" does not match "max_pool1d() Invalid computed output size: 0"

These seem to be the same to me?

[mikaylagawarecki]

@pytorchbot rebase

[pytorchmergebot]

@pytorchbot successfully started a rebase job. Check the current status here

[pytorchmergebot]

Successfully rebased onedpooling onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout onedpooling && git pull --rebase)

[mikaylagawarecki]

Thanks!

[mikaylagawarecki]

@pytorchbot merge

[pytorchmergebot]

Merge failed

Reason: This PR needs a label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team

Raised by workflow job

[tfsingh]

@pytorchbot label "error checking"

[pytorch-bot]

Didn't find following labels among repository labels: error checking

[tfsingh]

@pytorchbot label "module: error checking"

[tfsingh]

Hi @mikaylagawarecki , could you restart the merge when you get a chance? Thanks!

[mikaylagawarecki]

@pytorchbot rebase

[pytorchmergebot]

@pytorchbot successfully started a rebase job. Check the current status here

[pytorchmergebot]

Successfully rebased onedpooling onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout onedpooling && git pull --rebase)

[mikaylagawarecki]

@pytorchbot merge

[pytorchmergebot]

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here