Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix listing of updated keys in collectors #2460

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Oct 1, 2024

The listing of updated keys in the collector after running the policy checks that an entry is either new or updated or updated and not identical, when it should be new OR (updated AND not identical).

Copy link

pytorch-bot bot commented Oct 1, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2460

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures, 11 Unrelated Failures

As of commit 463a82c with merge base 1858bea (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 1, 2024
@vmoens vmoens added the bug Something isn't working label Oct 1, 2024
@vmoens vmoens merged commit 97ccbb7 into main Oct 1, 2024
63 of 75 checks passed
@vmoens vmoens deleted the fix-collector-keysupdate branch October 1, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants