Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove frontend UT suite execution from setup #522

Closed
harshbafna opened this issue Jul 13, 2020 · 0 comments · Fixed by #527
Closed

Remove frontend UT suite execution from setup #522

harshbafna opened this issue Jul 13, 2020 · 0 comments · Fixed by #527
Assignees
@harshbafna
Labels
enhancement New feature or request
Milestone
v0.2.0

Comments

@harshbafna
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Dusing install from source, Gradle build executes complete frontend UT suite thereby increasing the install time by a considerable amount.

Describe the solution

Setup should only generate the required frontend jar for installation and not execute the whole frontend UT suite.

Developers have the option to run frontend UT suite manually and this is also included in the torchserve_sanity script which is a part of the CI build process.
@harshbafna harshbafna added the enhancement New feature or request label Jul 13, 2020
@harshbafna harshbafna added this to the v0.2.0 milestone Jul 13, 2020
@harshbafna harshbafna self-assigned this Jul 13, 2020
@harshbafna harshbafna mentioned this issue Jul 13, 2020
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@harshbafna harshbafna

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging a pull request may close this issue.

Updated install scripts and removed frontend build from install pytorch/serve
1 participant
@harshbafna