Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated install scripts and removed frontend build from install #527

Merged
merged 18 commits into from
Jul 21, 2020
Merged

Updated install scripts and removed frontend build from install #527

merged 18 commits into from
Jul 21, 2020

Conversation

harshbafna
Copy link
Contributor

@harshbafna harshbafna commented Jul 13, 2020 •
edited
Loading

Description

  • replaced complete frontend build with assemble in setup.py, thereby removing the un-necessary UT suite execution on install from source.
  • unified install_from_src scripts for macOS and ubuntu
  • updated documentation for following
  • Code coverage and sanity script execution
  • Contributing readme
  • Main README as per changes in above scripts

Fixes #522

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Feature/Issue validation/testing

install from source mac.txt
install from source ubuntu.txt
install from src ubuntu gpu.txt
torchserve sanity macos.txt
torchserve sanity ubuntu.txt
torchserve sanity ubuntu gpu.txt

Checklist:

  • Have you added tests that prove your fix is effective or that this feature works?
  • New and existing unit tests pass locally with these changes?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

@harshbafna harshbafna added this to the v0.2.0 milestone Jul 13, 2020
@harshbafna harshbafna added the enhancement New feature or request label Jul 13, 2020
@harshbafna harshbafna self-assigned this Jul 13, 2020
@sagemaker-neo-ci-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: torch-serve-build-cpu
  • Commit ID: ff49d09
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-neo-ci-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: torch-serve-build-gpu
  • Commit ID: ff49d09
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-neo-ci-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: torch-serve-build-cpu
  • Commit ID: b57dfc6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-neo-ci-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: torch-serve-build-gpu
  • Commit ID: b57dfc6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@harshbafna harshbafna marked this pull request as ready for review July 13, 2020 13:53
@sagemaker-neo-ci-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: torch-serve-build-cpu
  • Commit ID: 392e4c2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

maaquib
maaquib requested changes Jul 17, 2020
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
docs/code_coverage.md Outdated Show resolved Hide resolved
setup.py Show resolved Hide resolved
chauhang
chauhang previously requested changes Jul 18, 2020
View reviewed changes
Copy link
Contributor

@chauhang chauhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harshbafna Few comments:

  1. Prev version of the script used to check if launching from conda env or outside. Can you please verify that check is not needed anymore

  2. How to do install from src on GPU machines? Can you please update the scripts and readme for this?

@harshbafna
Copy link
Contributor Author

@chauhang

  1. Prev version of the script used to check if launching from conda env or outside. Can you please verify that check is not needed anymore

Earlier there was just an echo statement asking the user to "exit if using a conda enviornment". However, we have been using the install from source scripts on DL AMIs and mac with conda since the first release without any issues. Hence removed the statement.

  1. How to do install from src on GPU machines? Can you please update the scripts and readme for this?

The same script works on both CPU and GPU.

harshbafna and others added 2 commits July 18, 2020 06:54
@dhanainme dhanainme requested review from maaquib and chauhang July 21, 2020 14:38
@dhanainme
Copy link
Collaborator

@chauhang @maaquib , This looks good to me.

Will go ahead & merge this today if you dont have anymore feedback

@sagemaker-neo-ci-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: torch-serve-build-cpu
  • Commit ID: a699b2c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-neo-ci-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: torch-serve-build-gpu
  • Commit ID: a699b2c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-neo-ci-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: torch-serve-build-cpu
  • Commit ID: e0414af
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-neo-ci-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: torch-serve-build-gpu
  • Commit ID: e0414af
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-neo-ci-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: torch-serve-build-cpu
  • Commit ID: d20fa36
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-neo-ci-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: torch-serve-build-gpu
  • Commit ID: d20fa36
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-neo-ci-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: torch-serve-build-cpu
  • Commit ID: 74486ed
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-neo-ci-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: torch-serve-build-gpu
  • Commit ID: 74486ed
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-neo-ci-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: torch-serve-build-cpu
  • Commit ID: 2ecf331
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-neo-ci-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: torch-serve-build-gpu
  • Commit ID: 2ecf331
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@maaquib
Copy link
Collaborator

maaquib commented Jul 21, 2020

Verified on GPU and CPU

./scripts/install_from_src
torchserve --start --model-store /tmp/model_store/
curl -X POST "http://localhost:8081/models?url=https://torchserve.s3.amazonaws.com/mar_files/my_text_classifier.mar&initial_workers=1&synchronous=true"

@maaquib maaquib merged commit 423f663 into master Jul 21, 2020
@sagemaker-neo-ci-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: torch-serve-build-cpu
  • Commit ID: 2ecf331
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-neo-ci-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: torch-serve-build-gpu
  • Commit ID: 2ecf331
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@harshbafna harshbafna deleted the issue_522 branch July 22, 2020 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maaquib maaquib maaquib approved these changes

@dhanainme dhanainme dhanainme approved these changes

@dhaniram-kshirsagar dhaniram-kshirsagar dhaniram-kshirsagar left review comments

@chauhang chauhang Awaiting requested review from chauhang

Assignees

@harshbafna harshbafna

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging this pull request may close these issues.

Remove frontend UT suite execution from setup
6 participants
@harshbafna @sagemaker-neo-ci-bot @dhanainme @maaquib @chauhang @dhaniram-kshirsagar