Issue 1120 #1271

lxning · 2021-10-06T00:09:19Z

Description

Please include a summary of the feature or issue being fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #(issue)
#1120

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

Feature/Issue validation/testing

Please describe the tests [UT/IT] that you ran to verify your changes and relevent result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

Test A
Test B
UT/IT execution results
Logs

Checklist:

Have you added tests that prove your fix is effective or that this feature works?
New and existing unit tests pass locally with these changes?
Has code been commented, particularly in hard-to-understand areas?
Have you made corresponding changes to the documentation?

sagemaker-neo-ci-bot · 2021-10-06T00:33:44Z

AWS CodeBuild CI Report

CodeBuild project: torch-serve-build-cpu
Commit ID: a5cd198
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-neo-ci-bot · 2021-10-06T00:37:15Z

AWS CodeBuild CI Report

CodeBuild project: torch-serve-build-win
Commit ID: a5cd198
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-neo-ci-bot · 2021-10-06T04:44:46Z

AWS CodeBuild CI Report

CodeBuild project: torch-serve-build-gpu
Commit ID: a5cd198
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-neo-ci-bot · 2021-10-08T01:22:50Z

AWS CodeBuild CI Report

CodeBuild project: torch-serve-build-cpu
Commit ID: 4dd1783
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-neo-ci-bot · 2021-10-08T01:26:31Z

AWS CodeBuild CI Report

CodeBuild project: torch-serve-build-win
Commit ID: 4dd1783
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-neo-ci-bot · 2021-10-08T02:21:05Z

AWS CodeBuild CI Report

CodeBuild project: torch-serve-build-cpu
Commit ID: e377bc0
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-neo-ci-bot · 2021-10-08T02:21:39Z

AWS CodeBuild CI Report

CodeBuild project: torch-serve-build-win
Commit ID: e377bc0
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-neo-ci-bot · 2021-10-08T02:46:33Z

AWS CodeBuild CI Report

CodeBuild project: torch-serve-build-gpu
Commit ID: 4dd1783
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-neo-ci-bot · 2021-10-08T04:17:58Z

AWS CodeBuild CI Report

CodeBuild project: torch-serve-build-cpu
Commit ID: 13ab7f5
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-neo-ci-bot · 2021-10-08T04:22:11Z

AWS CodeBuild CI Report

CodeBuild project: torch-serve-build-win
Commit ID: 13ab7f5
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-neo-ci-bot · 2021-10-08T11:07:03Z

AWS CodeBuild CI Report

CodeBuild project: torch-serve-build-gpu
Commit ID: 13ab7f5
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-neo-ci-bot · 2021-10-08T18:12:16Z

AWS CodeBuild CI Report

CodeBuild project: torch-serve-build-cpu
Commit ID: fb57045
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-neo-ci-bot · 2021-10-08T18:29:26Z

AWS CodeBuild CI Report

CodeBuild project: torch-serve-build-cpu
Commit ID: fb57045
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-neo-ci-bot · 2021-10-08T18:39:58Z

AWS CodeBuild CI Report

CodeBuild project: torch-serve-build-win
Commit ID: fb57045
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-neo-ci-bot · 2021-10-08T18:44:03Z

AWS CodeBuild CI Report

CodeBuild project: torch-serve-build-cpu
Commit ID: fb57045
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-neo-ci-bot · 2021-10-08T19:55:37Z

AWS CodeBuild CI Report

CodeBuild project: torch-serve-build-cpu
Commit ID: 6a57116
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-neo-ci-bot · 2021-10-08T20:24:10Z

AWS CodeBuild CI Report

CodeBuild project: torch-serve-build-win
Commit ID: 6a57116
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

HamidShojanazeri

Thanks @lxning I have successfully tested the PR with image size of 35 MB, here are the test and logs. I just left a minor comment on the doc.

HamidShojanazeri · 2021-10-08T20:50:02Z

docs/configuration.md

@@ -284,6 +284,7 @@ the backend workers convert "Bytearray to utf-8 string" when the Content-Type of
 * `model_server_home` : Torchserve home directory. 
 * `max_request_size` : The maximum allowable request size that the Torchserve accepts, in bytes. Default: 6553500
 * `max_response_size` : The maximum allowable response size that the Torchserve sends, in bytes. Default: 6553500
+* `limit_max_image_pixels` : Default value is true. If this is set to "false", PIL.Image.MAX_IMAGE_PIXELS = None in backend default vision handler. 


@lxning should we add some explanations that this setting would be helpful is running inference for images with size beyond 5MB (which I think is our current limit?).

Doc was updated.

sagemaker-neo-ci-bot · 2021-10-08T22:57:51Z

AWS CodeBuild CI Report

CodeBuild project: torch-serve-build-gpu
Commit ID: fb57045
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-neo-ci-bot · 2021-10-08T23:11:14Z

AWS CodeBuild CI Report

CodeBuild project: torch-serve-build-gpu
Commit ID: 6a57116
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-neo-ci-bot · 2021-10-11T18:07:05Z

AWS CodeBuild CI Report

CodeBuild project: torch-serve-build-cpu
Commit ID: 07da5ca
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-neo-ci-bot · 2021-10-11T18:35:49Z

AWS CodeBuild CI Report

CodeBuild project: torch-serve-build-win
Commit ID: 07da5ca
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-neo-ci-bot · 2021-10-12T21:35:59Z

AWS CodeBuild CI Report

CodeBuild project: torch-serve-build-cpu
Commit ID: 4e795f0
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-neo-ci-bot · 2021-10-12T21:36:14Z

AWS CodeBuild CI Report

CodeBuild project: torch-serve-build-win
Commit ID: 4e795f0
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-neo-ci-bot · 2021-10-12T21:38:43Z

AWS CodeBuild CI Report

CodeBuild project: torch-serve-build-gpu
Commit ID: 4e795f0
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-neo-ci-bot · 2021-10-12T22:30:14Z

AWS CodeBuild CI Report

CodeBuild project: torch-serve-build-gpu
Commit ID: 2a018f0
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-neo-ci-bot · 2021-10-12T22:39:50Z

AWS CodeBuild CI Report

CodeBuild project: torch-serve-build-cpu
Commit ID: 2a018f0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-neo-ci-bot · 2021-10-12T22:41:51Z

AWS CodeBuild CI Report

CodeBuild project: torch-serve-build-win
Commit ID: 2a018f0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-neo-ci-bot · 2021-10-12T23:26:27Z

AWS CodeBuild CI Report

CodeBuild project: torch-serve-build-cpu
Commit ID: d607dcc
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-neo-ci-bot · 2021-10-12T23:28:27Z

AWS CodeBuild CI Report

CodeBuild project: torch-serve-build-win
Commit ID: d607dcc
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-neo-ci-bot · 2021-10-12T23:33:56Z

AWS CodeBuild CI Report

CodeBuild project: torch-serve-build-gpu
Commit ID: d607dcc
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

nikhil-sk · 2021-11-05T22:42:04Z

docs/configuration.md

@@ -284,6 +284,7 @@ the backend workers convert "Bytearray to utf-8 string" when the Content-Type of
 * `model_server_home` : Torchserve home directory. 
 * `max_request_size` : The maximum allowable request size that the Torchserve accepts, in bytes. Default: 6553500
 * `max_response_size` : The maximum allowable response size that the Torchserve sends, in bytes. Default: 6553500
+* `limit_max_image_pixels` : Default value is true (Use default [PIL.Image.MAX_IMAGE_PIXELS](https://pillow.readthedocs.io/en/stable/reference/Image.html#PIL.Image.MAX_IMAGE_PIXELS)). If this is set to "false", set PIL.Image.MAX_IMAGE_PIXELS = None in backend default vision handler for large image payload. 


Hi @lxning, could you add more details on how the limit_max_image_pixels, fixes the related issue #1120 ? Or, at least aids in the resolution of the issue? [Request to add details in the PR description]. Is the idea that a user should be able to limit the size of the input image?

the detailed information is provided in the above link

nikhil-sk · 2021-11-05T22:50:28Z

ts/context.py

        }
        self.request_ids = None
        self.request_processor = None
        self._metrics = None
+        self._limit_max_image_pixels = True


Could you elaborate on how this is further used

nikhil-sk · 2021-11-05T22:54:12Z

ts/torch_handler/vision_handler.py

@@ -20,6 +20,9 @@ def initialize(self, context):
        super().initialize(context)
        self.ig = IntegratedGradients(self.model)
        self.initialized = True
+        properties = context.system_properties
+        if not properties.get("limit_max_image_pixels") :
+            Image.MAX_IMAGE_PIXELS = None


Here, we're setting value to None, however, it does not seem to be clear what happens if this value is not None, does PILLOW automatically pick it up from context?

Same as the above, the detailed information is provided in pillow link

sagemaker-neo-ci-bot · 2021-11-06T02:49:57Z

AWS CodeBuild CI Report

CodeBuild project: torch-serve-build-win
Commit ID: 3d30f4c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-neo-ci-bot · 2021-11-06T02:59:19Z

AWS CodeBuild CI Report

CodeBuild project: torch-serve-build-cpu
Commit ID: 3d30f4c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-neo-ci-bot · 2021-11-06T04:05:06Z

AWS CodeBuild CI Report

CodeBuild project: torch-serve-build-win
Commit ID: 3d30f4c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

lxning added 2 commits October 1, 2021 15:07

config DefaultHttpDataFactory size

8a8c363

add debug info

a5cd198

fmt

4dd1783

add limit_max_image_pixels

e377bc0

pass limitMaxImagePixels to backend

13ab7f5

lxning added 2 commits October 8, 2021 10:58

fix unit test

7d2f2d6

update doc

fb57045

Merge branch 'master' into issue_1120

6a57116

HamidShojanazeri approved these changes Oct 8, 2021

View reviewed changes

lxning added 2 commits October 11, 2021 11:02

update doc

01048fa

Merge branch 'issue_1120' of github.com:pytorch/serve into issue_1120

07da5ca

lxning requested a review from nikhil-sk October 11, 2021 18:06

fmt

4e795f0

fix unit test

2a018f0

Merge branch 'master' into issue_1120

d607dcc

lxning self-assigned this Oct 27, 2021

lxning added the enhancement New feature or request label Oct 27, 2021

lxning added this to the v0.4.3 milestone Oct 27, 2021

lxning changed the title ~~[WIP]Issue 1120~~ Issue 1120 Nov 1, 2021

nikhil-sk reviewed Nov 5, 2021

View reviewed changes

nikhil-sk approved these changes Nov 6, 2021

View reviewed changes

Merge branch 'master' into issue_1120

3d30f4c

lxning merged commit 72761c0 into master Nov 6, 2021

Issue 1120 #1271

Issue 1120 #1271

Conversation

lxning commented Oct 6, 2021 • edited Loading

Description

Type of change

Feature/Issue validation/testing

Checklist:

sagemaker-neo-ci-bot commented Oct 6, 2021

AWS CodeBuild CI Report

sagemaker-neo-ci-bot commented Oct 6, 2021

AWS CodeBuild CI Report

sagemaker-neo-ci-bot commented Oct 6, 2021

AWS CodeBuild CI Report

sagemaker-neo-ci-bot commented Oct 8, 2021

AWS CodeBuild CI Report

sagemaker-neo-ci-bot commented Oct 8, 2021

AWS CodeBuild CI Report

sagemaker-neo-ci-bot commented Oct 8, 2021

AWS CodeBuild CI Report

sagemaker-neo-ci-bot commented Oct 8, 2021

AWS CodeBuild CI Report

sagemaker-neo-ci-bot commented Oct 8, 2021

AWS CodeBuild CI Report

sagemaker-neo-ci-bot commented Oct 8, 2021

AWS CodeBuild CI Report

sagemaker-neo-ci-bot commented Oct 8, 2021

AWS CodeBuild CI Report

sagemaker-neo-ci-bot commented Oct 8, 2021

AWS CodeBuild CI Report

sagemaker-neo-ci-bot commented Oct 8, 2021

AWS CodeBuild CI Report

sagemaker-neo-ci-bot commented Oct 8, 2021

AWS CodeBuild CI Report

sagemaker-neo-ci-bot commented Oct 8, 2021

AWS CodeBuild CI Report

sagemaker-neo-ci-bot commented Oct 8, 2021

AWS CodeBuild CI Report

sagemaker-neo-ci-bot commented Oct 8, 2021

AWS CodeBuild CI Report

sagemaker-neo-ci-bot commented Oct 8, 2021

AWS CodeBuild CI Report

HamidShojanazeri left a comment

Choose a reason for hiding this comment

HamidShojanazeri Oct 8, 2021

Choose a reason for hiding this comment

lxning Oct 11, 2021

Choose a reason for hiding this comment

sagemaker-neo-ci-bot commented Oct 8, 2021

AWS CodeBuild CI Report

sagemaker-neo-ci-bot commented Oct 8, 2021

AWS CodeBuild CI Report

sagemaker-neo-ci-bot commented Oct 11, 2021

AWS CodeBuild CI Report

sagemaker-neo-ci-bot commented Oct 11, 2021

AWS CodeBuild CI Report

sagemaker-neo-ci-bot commented Oct 12, 2021

AWS CodeBuild CI Report

sagemaker-neo-ci-bot commented Oct 12, 2021

AWS CodeBuild CI Report

sagemaker-neo-ci-bot commented Oct 12, 2021

AWS CodeBuild CI Report

sagemaker-neo-ci-bot commented Oct 12, 2021

AWS CodeBuild CI Report

sagemaker-neo-ci-bot commented Oct 12, 2021

AWS CodeBuild CI Report

sagemaker-neo-ci-bot commented Oct 12, 2021

AWS CodeBuild CI Report

sagemaker-neo-ci-bot commented Oct 12, 2021

AWS CodeBuild CI Report

sagemaker-neo-ci-bot commented Oct 12, 2021

AWS CodeBuild CI Report

sagemaker-neo-ci-bot commented Oct 12, 2021

AWS CodeBuild CI Report

nikhil-sk Nov 5, 2021

Choose a reason for hiding this comment

lxning Nov 6, 2021

Choose a reason for hiding this comment

nikhil-sk Nov 5, 2021

Choose a reason for hiding this comment

lxning commented Oct 6, 2021 •

edited

Loading