-
Notifications
You must be signed in to change notification settings - Fork 863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate neuron Dockerfile in favor in DLC #1775
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1775 +/- ##
=======================================
Coverage 45.28% 45.28%
=======================================
Files 64 64
Lines 2597 2597
Branches 60 60
=======================================
Hits 1176 1176
Misses 1421 1421 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@rohithkrn please highlight deprecation message in README.md |
@lxning Updated. Thanks |
maaquib
reviewed
Aug 11, 2022
maaquib
approved these changes
Aug 15, 2022
msaroufim
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is to deprecate neuron dockerfile as it is currently broken. Instead, it's ideal at this to point use containers provided by aws/deep-learning-containers that are more reliable.
I also learnt that this was created to run performance tests but it was never run/tested.
Packages that are missing in this Dockerfile
python3.8, python3.8-dev, python3.8-venv, python3.8-distutils
. It installspython3-dev
gnupg
I tried installing these packages and ran the container but it did not detect neuron devices inside the container probably because of missing drivers.
Ran the docker container like below following https://awsdocs-neuron.readthedocs-hosted.com/en/latest/neuron-deploy/dlc-then-ec2-devflow.html#
docker run -it --name ts-jdk17 --rm --shm-size=1g -p 8080:8080 -p 8081:8081 -p 8082:8082 -e "AWS_NEURON_VISIBLE_DEVICES=ALL" -v $HOME/torchserve:/workspace ts-neuron-jdk17
Inside the container
neuron-ls
does not return anything.