Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added retry action for CI #1873

Merged
merged 13 commits into from
Jan 19, 2023
Merged

Added retry action for CI #1873

merged 13 commits into from
Jan 19, 2023

Conversation

agunapal
Copy link
Collaborator

Description

The CI runs can be flaky because of network issues.
Added a retry action to run the sanity script with the following properties

  • Timeout = 60 minutes
  • Max Retries = 3

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A
    Logs for Test A

  • Test B
    Logs for Test B

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

@msaroufim msaroufim added ci p0 high priority labels Sep 26, 2022
@codecov
Copy link

codecov bot commented Dec 14, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@221da4e). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1873   +/-   ##
=========================================
  Coverage          ?   53.38%           
=========================================
  Files             ?       71           
  Lines             ?     3224           
  Branches          ?       56           
=========================================
  Hits              ?     1721           
  Misses            ?     1503           
  Partials          ?        0           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@msaroufim msaroufim self-requested a review December 20, 2022 00:42
@msaroufim msaroufim requested a review from mreso January 18, 2023 01:26
@msaroufim
Copy link
Member

@agunapal what do you think should we merge this?

@mreso mreso merged commit 2d1bd26 into master Jan 19, 2023
@agunapal agunapal deleted the ci/retry_failed_command branch November 9, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci p0 high priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants