-
Notifications
You must be signed in to change notification settings - Fork 863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies for python3.10 #1999
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1999 +/- ##
=======================================
Coverage 53.31% 53.31%
=======================================
Files 70 70
Lines 3157 3157
Branches 56 56
=======================================
Hits 1683 1683
Misses 1474 1474 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please add test log?
I tried this PR on ubuntu, it does not work.
python ts_scripts/install_dependencies.py --environment dev
note: This error originates from a subprocess, and is likely not a problem with pip. |
I was looking into this. transformers version 4.11.0 doesn't work with Python 3.10, Do we have a dependency for using the version 4.11.0 of transformers @HamidShojanazeri @msaroufim |
I suspect the rust issue would go away if we just upgrade pip as part of CI. Regardless no I don't think we should pin to older versions of transformer, the example might break though if are using a preuploaded mar file instead of generating it for tests |
I tried upgrading pip. That didnt work. |
Py310 is fixed in #2031. so close this one. |
Description
Update dependencies for python3.10 support.
Had to install rust in dependencies since tokenizers pip wheel would fail without it.
Issue: #1959