Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix reponse timeout unit #2015

Merged
merged 2 commits into from
Dec 1, 2022
Merged

fix reponse timeout unit #2015

merged 2 commits into from
Dec 1, 2022

Conversation

lxning
Copy link
Collaborator

@lxning lxning commented Nov 30, 2022

Description

Please read our CONTRIBUTING.md prior to creating your first pull request.

Please include a summary of the feature or issue being fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #(issue)
#1984

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A
    Logs for Test A

  • Test B
    Logs for Test B

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

@lxning lxning requested review from msaroufim, maaquib and namannandan and removed request for msaroufim November 30, 2022 22:38
@lxning lxning self-assigned this Nov 30, 2022
@lxning lxning added the documentation Improvements or additions to documentation label Nov 30, 2022
@lxning lxning added this to the v0.7.0 milestone Nov 30, 2022
@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Merging #2015 (4122b71) into master (8b6726e) will not change coverage.
The diff coverage is n/a.

❗ Current head 4122b71 differs from pull request most recent head 1f57944. Consider uploading reports for the commit 1f57944 to get more accurate results

@@           Coverage Diff           @@
##           master    #2015   +/-   ##
=======================================
  Coverage   53.80%   53.80%           
=======================================
  Files          70       70           
  Lines        3169     3169           
  Branches       56       56           
=======================================
  Hits         1705     1705           
  Misses       1464     1464           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@msaroufim msaroufim self-requested a review December 1, 2022 00:49
@msaroufim msaroufim merged commit 1bfbbc6 into master Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants