Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8 is incorrect in batch_size, must use 3 instead #2049

Merged
merged 2 commits into from
Jan 5, 2023

Conversation

MasoudKaviani
Copy link
Contributor

@MasoudKaviani MasoudKaviani commented Jan 2, 2023

Description

Please read our CONTRIBUTING.md prior to creating your first pull request.

Please include a summary of the feature or issue being fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A
    Logs for Test A

  • Test B
    Logs for Test B

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

@msaroufim
Copy link
Member

Not sure I follow, could you elaborate on why 8 is an incorrect batch size?

@maaquib
Copy link
Collaborator

maaquib commented Jan 4, 2023

Not sure I follow, could you elaborate on why 8 is an incorrect batch size?

@msaroufim The load model command in line 118 has batch_size=3 as a param

@msaroufim msaroufim self-requested a review January 4, 2023 00:40
@codecov
Copy link

codecov bot commented Jan 4, 2023

Codecov Report

Merging #2049 (0b392c8) into master (97d66e6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2049   +/-   ##
=======================================
  Coverage   53.38%   53.38%           
=======================================
  Files          71       71           
  Lines        3224     3224           
  Branches       56       56           
=======================================
  Hits         1721     1721           
  Misses       1503     1503           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@msaroufim msaroufim merged commit 23451e8 into pytorch:master Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants