Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update runner label in regression_tests_gpu.yml #2080

Merged
merged 3 commits into from
Jan 30, 2023
Merged

update runner label in regression_tests_gpu.yml #2080

merged 3 commits into from
Jan 30, 2023

Conversation

lxning
Copy link
Collaborator

@lxning lxning commented Jan 18, 2023

Description

Please read our CONTRIBUTING.md prior to creating your first pull request.

Please include a summary of the feature or issue being fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #(issue)
#2079

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A
    Logs for Test A

  • Test B
    Logs for Test B

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@714c2f2). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2080   +/-   ##
=========================================
  Coverage          ?   53.36%           
=========================================
  Files             ?       71           
  Lines             ?     3225           
  Branches          ?       56           
=========================================
  Hits              ?     1721           
  Misses            ?     1504           
  Partials          ?        0           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@msaroufim
Copy link
Member

Should we update this from running on workflow dispatch to running on every commit or nightly?

@lxning lxning self-assigned this Jan 18, 2023
@lxning lxning added the ci label Jan 18, 2023
@lxning lxning added this to the v0.7.1 milestone Jan 18, 2023
@agunapal
Copy link
Collaborator

Yes, we could change it to run on a nightly basis. It takes around 90 minutes ti run i think.

@lxning lxning merged commit 9e2b27f into master Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants