Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.1 documentation updates (rollup) #212

Merged
merged 57 commits into from
Apr 20, 2020
Merged

0.1 documentation updates (rollup) #212

merged 57 commits into from
Apr 20, 2020

Conversation

aaronmarkham
Copy link
Contributor

@aaronmarkham aaronmarkham commented Apr 17, 2020 •
edited
Loading

These can be closed:
[x] Fixes #181 - examples readme text error
[x] Fixes #184 - broken link
[x] Rolls up #188 - fixes a broken link in #184
[x] Rolls up #194 - examples readme overhaul
[x] Rolls up #197 - main readme overhaul
[x] Deconflicts #198 - random docs fixes
[x] Fixes #207 - links verified; changed to relative

These issues related to docs and that might be 0.1 launch blockers are WIP:
[ ] #191 - owner: harsh/manoj
[ ] #203 - owner: ?
[ ] #205 - owner: harsh/manoj

Will review any additional patches from the WIP group and merge as they come in.

harshbafna and others added 21 commits April 11, 2020 09:30
@harshbafna
fixed broken lins
23164a3
@dhaniram-kshirsagar
Corrected examples doc
f879457
@dhaniram-kshirsagar
direct link to image classifier instead of individual model
d68f3c3
@dhaniram-kshirsagar
Update README.md
725a391
@dhaniram-kshirsagar
Update README.md
01d8c85
@eslesar-aws
documentation: edited main README.md, fixed links in docs/README.md, …
cde0b26 
…and removed redundant docs/quick_start.md topic
@eslesar-aws
documentation: added clone repo info to serve quick start example on …
33c61cb 
…README.md
@harshbafna
fixed minor doc issues found during testing
843ecd2
@eslesar-aws
documentation: removed mention of CentOS from README.md
5a31ad6
Merge branch 'eric_readme' into 0.1_docs
0962237
Merge branch 'imageclass_links' into 0.1_docs
158732c
Merge branch 'examples_readme' into 0.1_docs
4277349
@aaronmarkham
revert readme changes
5f36fd2
@aaronmarkham
Merge branch 'random_fixes' into 0.1_docs
f717388
@aaronmarkham
simply install instructions; clarify Docker quickstart
b6207b6
@aaronmarkham
add pip instructions and java note
697be82
@aaronmarkham
Merge pull request #209 from aaronmarkham/0.1_docs
ade8e7d 
Combine docs updates
@aaronmarkham
fix bullets
20a34fd
@aaronmarkham
Merge pull request #210 from aaronmarkham/0.1_docs
2f68b8e 
fix bullets
@aaronmarkham
change static links to relative
1eb3c2a
@aaronmarkham
Merge pull request #211 from aaronmarkham/0.1_docs
aa074d3 
change static links to relative
@sagemaker-neo-ci-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: torch-serve-build-cpu
  • Commit ID: aa074d3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-neo-ci-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: torch-serve-build-gpu
  • Commit ID: aa074d3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aaronmarkham aaronmarkham added the documentation Improvements or additions to documentation label Apr 17, 2020
fbbradheintz
fbbradheintz suggested changes Apr 17, 2020
View reviewed changes
@fbbradheintz fbbradheintz mentioned this pull request Apr 17, 2020
Closed
This was referenced Apr 18, 2020
Closed
Closed
@sagemaker-neo-ci-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: torch-serve-build-gpu
  • Commit ID: 4d6f68b
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aaronmarkham aaronmarkham mentioned this pull request Apr 20, 2020
Closed
harshbafna and others added 16 commits April 20, 2020 10:25
@harshbafna @aaronmarkham
fixed broken lins
f3835f9
@dhaniram-kshirsagar @aaronmarkham
Corrected examples doc
9918d90
@dhaniram-kshirsagar @aaronmarkham
direct link to image classifier instead of individual model
760b07b
@dhaniram-kshirsagar @aaronmarkham
Update README.md
ad3a2ca
@dhaniram-kshirsagar @aaronmarkham
Update README.md
1ff4d44
@eslesar-aws @aaronmarkham
documentation: edited main README.md, fixed links in docs/README.md, …
2281d23 
…and removed redundant docs/quick_start.md topic
@eslesar-aws @aaronmarkham
documentation: added clone repo info to serve quick start example on …
222040d 
…README.md
@harshbafna @aaronmarkham
fixed minor doc issues found during testing
a70d068
@eslesar-aws @aaronmarkham
documentation: removed mention of CentOS from README.md
cddd5cf
@aaronmarkham
revert readme changes
d020a3b
@aaronmarkham
simply install instructions; clarify Docker quickstart
82d3ace
@aaronmarkham
add pip instructions and java note
631f07b
@aaronmarkham
fix bullets
7b69d1d
@aaronmarkham
change static links to relative
a2b6125
@aaronmarkham
resolve feedback; fix formatting issues
74f205a
@aaronmarkham
Merge pull request #229 from aaronmarkham/0.1_docs
0335cd3 
0.1 docs
@sagemaker-neo-ci-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: torch-serve-build-cpu
  • Commit ID: 0335cd3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-neo-ci-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: torch-serve-build-gpu
  • Commit ID: 0335cd3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Manoj Rao and others added 2 commits April 20, 2020 22:34
Improve SSL instructions usage
97c4950 
The examples with SSL usage section show you how to
create a self-signed ceritficate. If the user follows
this then they should be passing appropriate flags to
their http client. Show the correct flags for curl.
@aaronmarkham
Merge pull request #231 from pytorch/ssl_usage
dbe9d9a 
Improve SSL instructions usage
@sagemaker-neo-ci-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: torch-serve-build-cpu
  • Commit ID: dbe9d9a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-neo-ci-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: torch-serve-build-gpu
  • Commit ID: dbe9d9a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mycpuorg mycpuorg self-requested a review April 20, 2020 22:57
@mycpuorg mycpuorg merged commit 995987a into master Apr 20, 2020
@sagemaker-neo-ci-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: torch-serve-build-cpu
  • Commit ID: dbe9d9a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-neo-ci-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: torch-serve-build-gpu
  • Commit ID: dbe9d9a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mycpuorg mycpuorg mycpuorg approved these changes

@fbbradheintz fbbradheintz fbbradheintz left review comments

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
7 participants
@aaronmarkham @sagemaker-neo-ci-bot @fbbradheintz @mycpuorg @harshbafna @dhaniram-kshirsagar @eslesar-aws