-
Notifications
You must be signed in to change notification settings - Fork 863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Github Code Scanning codeql.yml #2149
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2149 +/- ##
=======================================
Coverage 53.36% 53.36%
=======================================
Files 71 71
Lines 3225 3225
Branches 56 56
=======================================
Hits 1721 1721
Misses 1504 1504 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
.map(e -> e.split("=", 2)) | ||
.collect(Collectors.toMap(e -> e[0], e -> e[1])); | ||
|
||
ProcessBuilder pb = new ProcessBuilder(packageInstallCommand); |
Check failure
Code scanning / CodeQL
Building a command line with string concatenation
Description
This PR adds support for code scanning which detects a large suite of common vulnerabilities like code injection, directory traversal, bad crypto algorithms
So now our security process includes
Might also be useful to do
The security issues will show up in https://github.com/pytorch/serve/security/code-scanning after this is merged
Type of change
Feature/Issue validation/testing
Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Scroll down to CI, there should be 2 new jobs for code scanning, one for python and one for java
When both those jobs get completed a report gets created and it accurately shows some existing vulnerabilities we need to be fixing https://github.com/pytorch/serve/pull/2149/checks?check_run_id=11473788403
Checklist: