-
Notifications
You must be signed in to change notification settings - Fork 863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add KServe gRPC v2 support #2176
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2176 +/- ##
==========================================
+ Coverage 72.85% 72.86% +0.01%
==========================================
Files 78 78
Lines 3695 3697 +2
Branches 58 58
==========================================
+ Hits 2692 2694 +2
Misses 999 999
Partials 4 4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
async_result = await grpc_stub.Predictions(payload) | ||
return async_result | ||
|
||
def postprocess( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see this function is called. Could you add some comments (eg. which function call this one)?
) | ||
return self.grpc_client_stub | ||
|
||
async def _grpc_predict( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see this function is called. Could you add some comments (eg. which function call this one)?
Somebody, please! Get this man approve 🙂 |
Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
- add logs Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
4647802
to
456d476
Compare
Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jagadeeshi2i , Please check the regression failures.
Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
26c25bf
to
73a9f53
Compare
…serve-grpc Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
Description
Add gRPC support for KServe v2 protocol
Depends on #2175
Fixes #1859
Type of change
Please delete options that are not relevant.
Feature/Issue validation/testing
Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Test A
Logs for Test A
Test B
Logs for Test B
Checklist: