-
Notifications
You must be signed in to change notification settings - Fork 863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add zip-store option to model-archiver tool #2196
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2196 +/- ##
==========================================
+ Coverage 71.32% 71.57% +0.25%
==========================================
Files 73 73
Lines 3306 3307 +1
Branches 57 57
==========================================
+ Hits 2358 2367 +9
+ Misses 948 937 -11
- Partials 0 3 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mreso Looks good overall Can you please update this README with the new option and may be showing an example in the Readme? https://github.com/pytorch/serve/blob/master/model-archiver/README.md
2b8af82
to
88c1665
Compare
Thanks @agunapal I have added the help text but stopped short of an example as use case is primarily testing |
Description
This PR adds an option to our model-archiver tool to create a mar file without compression. This greatly speeds up the creation of the files which will enable us to reduce unit test time.
Type of change
Please delete options that are not relevant.
Feature/Issue validation/testing
Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Checklist: