-
Notifications
You must be signed in to change notification settings - Fork 863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix model-archiver to fail if extra files are missing #2212
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2212 +/- ##
==========================================
+ Coverage 70.69% 72.15% +1.45%
==========================================
Files 78 78
Lines 3638 3641 +3
Branches 57 58 +1
==========================================
+ Hits 2572 2627 +55
+ Misses 1063 1010 -53
- Partials 3 4 +1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
model-archiver/model_archiver/tests/integ_tests/test_integration_model_archiver.py
Show resolved
Hide resolved
@@ -164,6 +165,10 @@ def copy_artifacts(model_name, **kwargs): | |||
|
|||
if file_type == "extra_files": | |||
for path_or_wildcard in path.split(","): | |||
if not Path(path_or_wildcard).exists(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this "if" lead wildcard feature invalid @mreso
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
This PR lets the model-archiver fail if a file given in the extra-file list does not exist.
Additionally, it refactors the integration test to not start a subprocess to determine code coverage.
Type of change
Please delete options that are not relevant.
Feature/Issue validation/testing
Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Checklist: