-
Notifications
You must be signed in to change notification settings - Fork 863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor sanity checks to use pytest #2221
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2221 +/- ##
==========================================
- Coverage 72.44% 72.36% -0.08%
==========================================
Files 85 85
Lines 3963 3963
Branches 58 58
==========================================
- Hits 2871 2868 -3
- Misses 1088 1091 +3
Partials 4 4 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ead57e6
to
5d4fc08
Compare
Make sanity test run with pytest 90% Added missing test for snapshotting Use pytest tests in torchserve sanity checks
2a32a23
to
c558f95
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently regression test run test/pytest.
With these changes, tt seems that regression test will also run test_sanity. Do we need this duplicate work?
@@ -163,51 +162,18 @@ def run_rest_test(model, register_model=True, unregister_model=True): | |||
|
|||
|
|||
def test_sanity(): | |||
generate_grpc_client_stubs() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess sanity test will fail without gRPC client.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thats call is now a fixture
generate_grpc_client_stubs() |
@lxning good point! Have changes the PR so that sanity tests are ignored when regression tests run |
Description
This PR refactors parts of our sanity checks to use pytest infra which enables devs to test model registration + snapshotting using
Type of change
Please delete options that are not relevant.
Feature/Issue validation/testing
Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
See PR checks
Checklist: