-
Notifications
You must be signed in to change notification settings - Fork 863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor PT2 code changes #2222
Conversation
@morgandu FYI this is how we're gonna do the configs moving forward |
Codecov Report
@@ Coverage Diff @@
## master #2222 +/- ##
==========================================
+ Coverage 71.41% 71.47% +0.05%
==========================================
Files 73 73
Lines 3348 3341 -7
Branches 57 57
==========================================
- Hits 2391 2388 -3
+ Misses 954 950 -4
Partials 3 3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
… into msaroufim/pt2changes
… into msaroufim/pt2changes
Chatted with @morgandu offline the Kokoro TPU failure is expected since we're making a breaking change and getting rid of the |
… into msaroufim/pt2changes
|
||
|
||
@pytest.mark.skipif(PT_2_AVAILABLE == False, reason="torch version is < 2.0.0") | ||
class TestTorchCompile: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the functions such as test_start_torchserve, test_server_status, test_registered_model, and test_serve_inference can be generalized to be shared with the other test cases. This work can be done later.
|
||
`{"pt2" : "inductor"}` | ||
`pt2: "inductor"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this pr cover the feature enable/disable torch.compile flag?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No we discussed it verbally a few weeks ago to make that happen we'd need to be able to load a new config dynamically and not just package it with archiver. Right now users will see logs that compilation failed, they will fallback to non compiled model. Compilation will only be attempted if pt2 flag shows up in yaml so default behavior is unchanged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise
GitHub is acting up in CI. Whoever sees this tomorrow please merge |
@agunapal does the docker 3.10 CI failure look legit to you here? https://github.com/pytorch/serve/actions/runs/4739570657/jobs/8414522301?pr=2222 |
@msaroufim the 3.8 failure seems like a network issue. I am not sure about the 3.10 one. I guess we need to add a retry action for this . This is the first time i have seen it fail |
@agunapal btw regarding network failures I've noticed that if you make lots of network queries in a row even in the same github action then things start to fail,, I wonder if github intentionall has some rate limiting to avoid spam |
Description
Note: the link check lint keeps timing out so i might ignore it for now
Now that PT 2.0 was official released there's a few updates we needed to make
Type of change
Please delete options that are not relevant.
Feature/Issue validation/testing
Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Checklist: