Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes error thrown while loading multiple models #2235

Merged
merged 6 commits into from
Apr 20, 2023

Conversation

jagadeeshi2i
Copy link
Collaborator

Description

Fixes validation error thrown while loading multiple mar files.

Please read our CONTRIBUTING.md prior to creating your first pull request.

Please include a summary of the feature or issue being fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A
    Logs for Test A

  • Test B
    Logs for Test B

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Merging #2235 (fe76966) into master (9fa08a3) will decrease coverage by 0.12%.
The diff coverage is n/a.

❗ Current head fe76966 differs from pull request most recent head 719d5d1. Consider uploading reports for the commit 719d5d1 to get more accurate results

@@            Coverage Diff             @@
##           master    #2235      +/-   ##
==========================================
- Coverage   71.47%   71.35%   -0.12%     
==========================================
  Files          73       73              
  Lines        3341     3341              
  Branches       57       57              
==========================================
- Hits         2388     2384       -4     
- Misses        950      954       +4     
  Partials        3        3              

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@msaroufim msaroufim self-requested a review April 17, 2023 17:39
@agunapal agunapal merged commit e4dc84a into pytorch:master Apr 20, 2023
@yuzisun
Copy link

yuzisun commented May 22, 2023

Can we make sure we have tests for this? this is breaking a lot of users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants