Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[easy] lint fix broken windows conda link #2240

Merged
merged 2 commits into from
Apr 19, 2023
Merged

Conversation

msaroufim
Copy link
Member

@msaroufim msaroufim commented Apr 18, 2023

Test is the lint job

@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #2240 (e92e9a3) into master (fbdb26e) will not change coverage.
The diff coverage is n/a.

❗ Current head e92e9a3 differs from pull request most recent head d4764ea. Consider uploading reports for the commit d4764ea to get more accurate results

@@           Coverage Diff           @@
##           master    #2240   +/-   ##
=======================================
  Coverage   71.41%   71.41%           
=======================================
  Files          73       73           
  Lines        3348     3348           
  Branches       57       57           
=======================================
  Hits         2391     2391           
  Misses        954      954           
  Partials        3        3           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@msaroufim msaroufim merged commit 2fa042b into master Apr 19, 2023
@agunapal
Copy link
Collaborator

@msaroufim Looks like the original one works and the new one doesn't

@agunapal
Copy link
Collaborator

Should I revert this?

@msaroufim
Copy link
Member Author

This is strange since CI was all green when this was merged. Feel free to revert or forward fix

agunapal added a commit that referenced this pull request Apr 20, 2023
msaroufim added a commit that referenced this pull request Apr 20, 2023
This reverts commit 2fa042b.

Co-authored-by: Mark Saroufim <marksaroufim@fb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants