Make pre-commit usage clearer in error message #2241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msaroufim
changed the title
|
Ok something definitely broken in docker CI https://github.com/pytorch/serve/actions/runs/4739607940/jobs/8414589150?pr=2241 - I'm gonna ignore it to merge my other PRs |
agunapal
approved these changes
Apr 19, 2023
Codecov Report
@@ Coverage Diff @@
## master #2241 +/- ##
==========================================
- Coverage 71.47% 71.35% -0.12%
==========================================
Files 73 73
Lines 3341 3341
Branches 57 57
==========================================
- Hits 2388 2384 -4
- Misses 950 954 +4
Partials 3 3 see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
.github/workflows/lint.yml
Outdated
| @@ -76,7 +76,7 @@ jobs: | |||
| echo "pip install pre-commit" | |||
| echo "cd serve/" | |||
| echo "pre-commit install" | |||
| echo "pre-commit will lint your code for you, so git add and commit those new changes and this check should become green" | |||
| echo "git diff --name-only main | xargs pre-commit run --files" | |||
There was a problem hiding this comment.
I think it was still helpful to let the users know they need to install pre-commit then git add and commit
min-jean-cho
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.