Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to TorchServe page on pytorch.org #2243

Merged
merged 11 commits into from
Apr 20, 2023
Merged

Conversation

agunapal
Copy link
Collaborator

Description

Update TorchServe's documentation in https://pytorch.org/serve/

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Feature/Issue validation/testing

NA

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Merging #2243 (0d2b51c) into master (fa95a66) will decrease coverage by 0.09%.
The diff coverage is n/a.

❗ Current head 0d2b51c differs from pull request most recent head b9baa4b. Consider uploading reports for the commit b9baa4b to get more accurate results

@@            Coverage Diff             @@
##           master    #2243      +/-   ##
==========================================
- Coverage   71.47%   71.38%   -0.09%     
==========================================
  Files          73       73              
  Lines        3341     3341              
  Branches       57       57              
==========================================
- Hits         2388     2385       -3     
- Misses        950      953       +3     
  Partials        3        3              

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

docs/index.md Outdated Show resolved Hide resolved
Copy link
Member

@msaroufim msaroufim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nit

@msaroufim msaroufim added the easy label Apr 20, 2023
Copy link
Collaborator

@min-jean-cho min-jean-cho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some minor comments, otherwise LGTM

@agunapal agunapal merged commit 044bbc1 into master Apr 20, 2023
@agunapal agunapal deleted the issues/update_serve_doc branch April 20, 2023 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants