Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move misplaced config-file arg from torchserve to torch-model-archiver #2244

Merged
merged 2 commits into from
Apr 20, 2023
Merged

move misplaced config-file arg from torchserve to torch-model-archiver #2244

merged 2 commits into from
Apr 20, 2023

Conversation

samils7
Copy link
Contributor

@samils7 samils7 commented Apr 20, 2023

explained right above but it is just misplaced

Description

Please read our CONTRIBUTING.md prior to creating your first pull request.

Please include a summary of the feature or issue being fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A
    Logs for Test A

  • Test B
    Logs for Test B

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

explained right above but it is just misplaced
@msaroufim msaroufim added the easy label Apr 20, 2023
@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Merging #2244 (11e3503) into master (b03ac7d) will decrease coverage by 0.09%.
The diff coverage is n/a.

❗ Current head 11e3503 differs from pull request most recent head 1d37b2c. Consider uploading reports for the commit 1d37b2c to get more accurate results

@@            Coverage Diff             @@
##           master    #2244      +/-   ##
==========================================
- Coverage   71.47%   71.38%   -0.09%     
==========================================
  Files          73       73              
  Lines        3341     3341              
  Branches       57       57              
==========================================
- Hits         2388     2385       -3     
- Misses        950      953       +3     
  Partials        3        3              

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@msaroufim msaroufim merged commit 5974c71 into pytorch:master Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants