Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix torch.compile mac regression test #2250

Merged
merged 2 commits into from
Apr 21, 2023
Merged

Conversation

msaroufim
Copy link
Member

@msaroufim msaroufim commented Apr 20, 2023

Fixes #2249

Test

(torchnew) marksaroufim@marksaroufim-mbp serve % pytest test/pytest/test_torch_compile.py
================================================================================================================ test session starts ================================================================================================================
platform darwin -- Python 3.8.16, pytest-7.2.2, pluggy-1.0.0
rootdir: /Users/marksaroufim/Dev/serve
plugins: hypothesis-6.70.0
collected 5 items

test/pytest/test_torch_compile.py sssss                                                                                                                                                                                                       [100%]

@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Merging #2250 (6c6b88c) into master (4dc1983) will decrease coverage by 0.12%.
The diff coverage is n/a.

❗ Current head 6c6b88c differs from pull request most recent head 2536d44. Consider uploading reports for the commit 2536d44 to get more accurate results

@@            Coverage Diff             @@
##           master    #2250      +/-   ##
==========================================
- Coverage   70.40%   70.28%   -0.12%     
==========================================
  Files          75       75              
  Lines        3392     3392              
  Branches       57       57              
==========================================
- Hits         2388     2384       -4     
- Misses       1001     1005       +4     
  Partials        3        3              

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@msaroufim msaroufim requested a review from agunapal April 20, 2023 23:06
@msaroufim msaroufim merged commit 99ac63f into master Apr 21, 2023
@msaroufim msaroufim deleted the msaroufim/fix-compile-mac branch April 21, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression Tests on mac are failing
3 participants