Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dimension names and documentation for metrics with prior prometheus support #2281

Merged
merged 2 commits into from
Apr 27, 2023

Conversation

namannandan
Copy link
Collaborator

@namannandan namannandan commented Apr 27, 2023

Description

For metrics with prior prometheus support, i.e:

  • ts_inference_requests_total
  • ts_inference_latency_microseconds
  • ts_queue_latency_microseconds

ensure that the dimension names match what was setup earlier and also replace uuid dimension name with hostname
Updated dimension names are: ["model_name", "model_version", "hostname"]

Update metrics API endpoint docs to reflect caching metrics implementation and above dimension name updates.

Deprecate TS_METRICS_FORMAT configuration option in favor of TS_METRICS_MODE.

RFC: #1492

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Feature/Issue validation/testing

  • Unit tests
    Run as part of sanity in CI

  • Regression tests

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Merging #2281 (64575f6) into master (d6e072a) will not change coverage.
The diff coverage is n/a.

❗ Current head 64575f6 differs from pull request most recent head f5ea97d. Consider uploading reports for the commit f5ea97d to get more accurate results

@@           Coverage Diff           @@
##           master    #2281   +/-   ##
=======================================
  Coverage   69.82%   69.82%           
=======================================
  Files          77       77           
  Lines        3420     3420           
  Branches       57       57           
=======================================
  Hits         2388     2388           
  Misses       1029     1029           
  Partials        3        3           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@namannandan namannandan marked this pull request as ready for review April 27, 2023 15:15
@namannandan
Copy link
Collaborator Author

Updated dashboard screenshots in documentation:
Prometheus
Screen Shot 2023-04-26 at 4 19 29 PM
Grafana
Screen Shot 2023-04-26 at 4 45 05 PM

@msaroufim msaroufim merged commit 1707a74 into pytorch:master Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants