-
Notifications
You must be signed in to change notification settings - Fork 863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing FAQs doc per issue #2204 #2351
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to fix a broken link in index.md where the trailing .md is cut off from the management_api.md. Added an anchor link to force the .md to show up.
Update to index.md to fix several links ending in .md that sphinx is breaking. Added anchor links to each link and a corresponding anchor in the affected doc. Tested locally and seems to be working.
Fixed typos and updated wordslist.txt
Updated a couple of broken links on the FAQ site per issue pytorch#2204
Updated some links in index.md to go to the pytorch html page instead of github. This is a nicer fix for the .md sphinx issue
Codecov Report
@@ Coverage Diff @@
## master #2351 +/- ##
==========================================
- Coverage 69.44% 69.36% -0.09%
==========================================
Files 77 77
Lines 3450 3450
Branches 57 57
==========================================
- Hits 2396 2393 -3
- Misses 1051 1054 +3
Partials 3 3 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
msaroufim
requested review from
lxning,
namannandan,
agunapal and
msaroufim
and removed request for
lxning and
namannandan
May 18, 2023 03:41
msaroufim
approved these changes
May 18, 2023
agunapal
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please read our CONTRIBUTING.md prior to creating your first pull request.
Please include a summary of the feature or issue being fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #2204
Type of change
Please delete options that are not relevant.
Feature/Issue validation/testing
Updated FAQs page to correct broken links. This started with issue #2204 but found a couple more links to be updated.
Also updated 3 Index links to go to the pytorch website instead of github. This is is a cleaner solution for the .md sphinx issue.
Tested by building site locally and previewing the different pages. Attached screenshot of of the tests.
Checklist: