-
Notifications
You must be signed in to change notification settings - Fork 863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable ONNX test in CI #2363
Merged
Merged
Enable ONNX test in CI #2363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msaroufim
commented
May 25, 2023
Codecov Report
@@ Coverage Diff @@
## master #2363 +/- ##
==========================================
+ Coverage 69.44% 72.15% +2.70%
==========================================
Files 77 78 +1
Lines 3450 3641 +191
Branches 57 58 +1
==========================================
+ Hits 2396 2627 +231
+ Misses 1051 1010 -41
- Partials 3 4 +1
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
msaroufim
changed the title
Enable ONNX test in CI
Enable ONNX test in CI and Enable Regression test on PR
May 27, 2023
msaroufim
changed the title
Enable ONNX test in CI and Enable Regression test on PR
Enable ONNX test in CI
May 31, 2023
namannandan
approved these changes
May 31, 2023
agunapal
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ONNX is one of our most popular model optimization runtimes, we shouldn't disable this test in CI by default anymore, it's hiding basic failures
Our CI takes 40min and our regression tests take 1h and for context the PyTorch CI takes around 4h. Would just suggest we run regression tests on CI all the time otherwise we get dumb bugs
Fixes #2360