Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression test failures #2371

Merged
merged 2 commits into from
May 31, 2023
Merged

Conversation

namannandan
Copy link
Collaborator

@namannandan namannandan commented May 30, 2023

Description

Fix regression test failures associated with kserve PR: #2175
Breaking change: https://github.com/pytorch/serve/pull/2175/files#diff-57322aac10a7e3d1c0a846bba41af9ca7947ec12bf05f0a27c4a080cd885ac4aR170

Fixes #2366

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Sanity and regression tests in CI

@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #2371 (8c84742) into master (81c3d59) will not change coverage.
The diff coverage is n/a.

❗ Current head 8c84742 differs from pull request most recent head 3810ff9. Consider uploading reports for the commit 3810ff9 to get more accurate results

@@           Coverage Diff           @@
##           master    #2371   +/-   ##
=======================================
  Coverage   72.15%   72.15%           
=======================================
  Files          78       78           
  Lines        3641     3641           
  Branches       58       58           
=======================================
  Hits         2627     2627           
  Misses       1010     1010           
  Partials        4        4           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@namannandan namannandan marked this pull request as ready for review May 31, 2023 01:27
@agunapal agunapal merged commit 130a29e into pytorch:master May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression tests failing
3 participants