-
Notifications
You must be signed in to change notification settings - Fork 863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cpuinfo #2372
Update cpuinfo #2372
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2372 +/- ##
==========================================
+ Coverage 72.06% 72.15% +0.08%
==========================================
Files 78 78
Lines 3641 3641
Branches 58 58
==========================================
+ Hits 2624 2627 +3
+ Misses 1013 1010 -3
Partials 4 4 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@namannandan might need to rebase your PR on top of this to get a green run Thanks @min-jean-cho do you have some local logs showing this working? The kserve failure will show up first and I don't believe the ipex test will run yet |
Thanks @msaroufim, I have verified locally that |
I see that the IPEX tests are now skipped. Do we intend to skip them in CI and only run them when required on a separate host?
https://github.com/pytorch/serve/actions/runs/5135850418/jobs/9241818474?pr=2372#step:6:9673 |
Is |
This is what runs https://github.com/pytorch/serve/blob/master/.github/workflows/regression_tests_cpu.yml#L38 - would suggest installing numactl in our dev dependencies install script |
This was merged a bit early I believe, I still see an error in master |
fix https://github.com/pytorch/serve/actions/runs/5127306973/jobs/9222779652?pr=2371#step:6:10294