Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cpuinfo #2372

Merged
merged 11 commits into from
May 31, 2023
Merged

Update cpuinfo #2372

merged 11 commits into from
May 31, 2023

Conversation

min-jean-cho
Copy link
Collaborator

@min-jean-cho min-jean-cho marked this pull request as ready for review May 31, 2023 03:48
@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Merging #2372 (f3bdd85) into master (27a6ed5) will increase coverage by 0.08%.
The diff coverage is n/a.

❗ Current head f3bdd85 differs from pull request most recent head 38ab17d. Consider uploading reports for the commit 38ab17d to get more accurate results

@@            Coverage Diff             @@
##           master    #2372      +/-   ##
==========================================
+ Coverage   72.06%   72.15%   +0.08%     
==========================================
  Files          78       78              
  Lines        3641     3641              
  Branches       58       58              
==========================================
+ Hits         2624     2627       +3     
+ Misses       1013     1010       -3     
  Partials        4        4              

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@msaroufim msaroufim self-requested a review May 31, 2023 04:36
@msaroufim
Copy link
Member

msaroufim commented May 31, 2023

@namannandan might need to rebase your PR on top of this to get a green run

Thanks @min-jean-cho do you have some local logs showing this working? The kserve failure will show up first and I don't believe the ipex test will run yet

@min-jean-cho
Copy link
Collaborator Author

Thanks @msaroufim, I have verified locally that test_example_intel_extension_for_pytorch succeeds, here is output logs.

@msaroufim msaroufim requested a review from agunapal May 31, 2023 18:02
@namannandan
Copy link
Collaborator

namannandan commented May 31, 2023

I see that the IPEX tests are now skipped. Do we intend to skip them in CI and only run them when required on a separate host?

test_example_intel_extension_for_pytorch.py::test_single_worker_affinity SKIPPED [  5%]
test_example_intel_extension_for_pytorch.py::test_multi_worker_affinity SKIPPED [  6%]
test_example_intel_extension_for_pytorch.py::test_worker_scale_up_affinity SKIPPED [  7%]
test_example_intel_extension_for_pytorch.py::test_worker_scale_down_affinity SKIPPED [  8%]

https://github.com/pytorch/serve/actions/runs/5135850418/jobs/9241818474?pr=2372#step:6:9673

@min-jean-cho
Copy link
Collaborator Author

Is numactl installed in CI?

@msaroufim
Copy link
Member

This is what runs https://github.com/pytorch/serve/blob/master/.github/workflows/regression_tests_cpu.yml#L38 - would suggest installing numactl in our dev dependencies install script

@agunapal agunapal merged commit c685b5c into pytorch:master May 31, 2023
@msaroufim
Copy link
Member

This was merged a bit early I believe, I still see an error in master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants