Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cu118 from regression tests #2380

Merged
merged 2 commits into from
Jun 1, 2023
Merged

Conversation

agunapal
Copy link
Collaborator

@agunapal agunapal commented Jun 1, 2023

Description

Regression GPU test queue is longer because we have to test cu117 and cu118.
We just need one version

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A
    Logs for Test A

  • Test B
    Logs for Test B

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

@agunapal agunapal requested a review from msaroufim June 1, 2023 16:56
@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Merging #2380 (f9410bb) into master (a81fc52) will not change coverage.
The diff coverage is n/a.

❗ Current head f9410bb differs from pull request most recent head e2c3060. Consider uploading reports for the commit e2c3060 to get more accurate results

@@           Coverage Diff           @@
##           master    #2380   +/-   ##
=======================================
  Coverage   72.13%   72.13%           
=======================================
  Files          78       78           
  Lines        3642     3642           
  Branches       58       58           
=======================================
  Hits         2627     2627           
  Misses       1011     1011           
  Partials        4        4           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@mreso mreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agunapal agunapal merged commit 77f8c0b into master Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants