-
Notifications
You must be signed in to change notification settings - Fork 863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker Regression Tests Github action #2403
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2403 +/- ##
=======================================
Coverage 71.89% 71.89%
=======================================
Files 78 78
Lines 3654 3654
Branches 58 58
=======================================
Hits 2627 2627
Misses 1023 1023
Partials 4 4 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved assuming CI is green on those images - for the failing test tracker please create a seperate github issue
run: | | ||
echo "Cleaning up previous run" | ||
ls -la ./ | ||
sudo rm -rf ./* || true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Why do we need the || true
part? Does this command fail in certain conditions and we want to ignore it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, there are weird permission issues because of pycache geenrated by docker run. This logic worked for me. Will have to monitor the runs for the next few days
cd docker | ||
./build_image.sh -g -cv cu117 -bt ci -b $GITHUB_REF_NAME -t pytorch/torchserve:ci | ||
- name: Torchserve GPU Regression Tests | ||
if: false == contains(matrix.hardware, 'ubuntu') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Would it be better check for the specific GPU runner attributes/labels instead of absence of ubuntu
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried, the problem is that we need to check for the entire thing: [self.hosted, ...] . I couldnt get it to work , hence went for the negation logic.
Re-requested review after new changes. GitHub doesn't seem to reflect it.
Description
This PR creates a github action to build TorchServe Docker Images and run regression tests inside a docker container
To make this happen,
Fix these Pytests
Fixes #(issue)
Type of change
Please delete options that are not relevant.
Feature/Issue validation/testing
2_docker-regression (self-hosted, regression-test-gpu).txt
1_docker-regression (ubuntu-20.04).txt
Checklist: